[Core] Bump up object fetch timeout in release test #60016
Conversation
Signed-off-by: joshlee <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the object fetch timeout to 30 minutes for a release test that simulates transient network errors. This is a reasonable change to fix test flakiness. My feedback includes one suggestion to add a comment to the timeout value for better readability.
| - RAY_health_check_timeout_ms=100000 | ||
| - RAY_health_check_failure_threshold=10 | ||
| - RAY_gcs_rpc_server_connect_timeout_s=60 | ||
| - RAY_fetch_fail_timeout_milliseconds=1800000 |
There was a problem hiding this comment.
For better readability and maintainability, consider adding a comment to clarify that this value represents 30 minutes. This helps other developers understand the value at a glance without having to perform the calculation.
- RAY_fetch_fail_timeout_milliseconds=1800000 # 30 minutes
ray-gardener
bot
added
core
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
github-actions
bot
added
unstale
1 participant
Object fetch's may take a while when in the presence of transient network errors due to long reconstruction chains + when push/pull fails we need to resend over all the chunks again. Hence we were seeing some ObjectFetchTimeout errors in the cross AZ transient network error release tests due to this, bumping up the timeout from 10 min to 30 min accordingly.